Allow decoration of AdminContextFactory #7101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrosse
changed the title
javiereguiluz
force-pushed
the
feature/allow-decaration-of-admin-context-factory
branch
from
af84e92 to
7c7f36a
Compare
Collaborator
|
Thank you @ogrosse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the decoration of EasyCorp\Bundle\EasyAdminBundle\Router\AdminRouteGenerator
When you decorate this class, you have an error because the AdminContextFactory construct need exactly this class and didn't expect the interface instead.
This MR replace with the interface, now it's possible to give a decorated class implement the same interface.